Extend usage of build-status.js

PyvesB commented 5 years ago

A number of services display information about the current build status (for example: ), however, we do not always do things consistently:

in terms of Joi schema validation, some have very strict validation (e.g. AzureDevOpsBuild), others have rather loose validation (e.g. Wercker). The isBuildStatus validator in build-status.js provides a good compromise, with rather strict validation but flexibility thanks to the wide range of accepted keywords.
the displayed text and colours are not necessarily consistent either.

See discussions in #2660 for more information. We should go through our refactored services and use the functions in build-status.js where appropriate.

The isBuildStatus validator in test-validators.js is now duplicated, shall we remove it and use the one from build-status.js inside our tests?

paulmelnikow commented 5 years ago

The isBuildStatus validator in test-validators.js is now duplicated, shall we remove it and use the one from build-status.js inside our tests?

It's the same list? Then I say definitely! 👍

PyvesB commented 5 years ago

Completed in the two linked pull requests, closing.

badges / shields

Extend usage of build-status.js #2706