Project Feedback!

[codepathreview]

:+1: nice work. A few notes after checking out the code:

• Good work on a clean UI
• Good to see you were able to format the timestamp cleanly
• Good to see you refreshed the timeline after composing a new tweet
• Nice touch with the character count being displayed while the user composes a tweet
• Nice to see you used a SwipeRefreshLayout library for easy timeline refreshes
• Glad to see you made the compose activity into a dialog instead
• Good to see you added DBFlow annotations to the models
• Good job adding offline support
• Consider adding [progress bars] (http://guides.codepath.com/android/Handling-ProgressBars#actionbar-progress-bar) to your app whenever a network request goes out
• The code looks clean in general with properly named methods. But you have call to statuses/home_timeline.json 3 times in TimelineActivity via 2 client methods. Ideally it should be 1 client method and 1 method in activity making the call. Also some of the methods in activity and adapter are too long. Those should be refactored into smaller logical chunks.
• Consider better organizing your source files

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

[codepathreview]

Hello Badhri,

Please update your README.md to include a GIF or video walkthrough as described here and then re-submit your project through the course system.

[badhrijagan06]

Imgur does not like me today.. I have uploaded the mp4 to dropbox and have added it to readme as well.. here is the link: https://www.dropbox.com/l/scl/AACaazVsFd6aCo7qUH5H2EM33pyiQ0TLAVU Apologies that I couldnt upload to imgur

[badhrijagan06]

here is the sendvid link as well: http://sendvid.com/0udssr2n

[codepathreview]

:+1: Nice work. A few notes after checking out the code:

• Architecting the fragments (base class and extension classes) should be done such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ, you have a lot of code duplication
• You also have code duplication in the client class in various getTimeline methods.
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nice to see you used the ViewPager to properly setup the tabs
• Good to see you played with styling
• Try to break long methods into smaller methods, it makes the code maintainable and readable.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.