badleyy / rtapi

The backend api for raft
0 stars 0 forks source link

[RTAPI-6] - Implemented the registration functionality. Also included … #2

Closed cpb2948 closed 8 years ago

cpb2948 commented 8 years ago

…a global exception handlers that returns json. To be used only in production.

cpb2948 commented 8 years ago

Sorry if some of this is off. I haven't use git before

dadleyy commented 8 years ago

lol dont bother with "assigning" it to people. just @ me and I'll look at it.

I'm still not convinced why the account and user data models should be separate. what's your thinking there?

dadleyy commented 8 years ago

good job with the commit message though. thats what i'm looking for.

cpb2948 commented 8 years ago

The reason i broke it up was to differentiate the site specific information and auth, such as a username and password from the real life information such as firstname lastname etc. If down the line we implement like user roles such as an admin or whatever or we decide we want to try "sign in using facebook" a real person may have multiple accounts. Also if we add more information such as state, zip, street it just prevents the table from getting massive.

dadleyy commented 8 years ago

I still think we could get away with a single users table:

user table:

column name type notes
id integer
email string
username string
password string
date_create datetime
last_login datetime
address_1 string
address_2 string
state integer foreign key to state table?
country integer foreign key to country table?

as far as integrations with facebook and other apps go, don't over-engineer this thing right now. we could always create a separate table for tracking facebook user ids and stuff like that:

_third_partyaccount table (or something like that)

column name type notes
id integer
user_id integer foreign key to user
provider enum?
oauth_token string
refresh_token string
foreign_id string
cpb2948 commented 8 years ago

Sure i can change it. It doesn't really matter to me much. Its just how it came to mind when i was creating the tables. We have it separated at work as well. Ill make a task to change that over, ill update the migrations and database seeds

cpb2948 commented 8 years ago

as well as any of the existing code we have that uses the account information

dadleyy commented 8 years ago

alrighty. I'm whippin up the clientside foundation and will push soon. pretty experimental stuff.

cpb2948 commented 8 years ago

Do you know of any like design tools or software? Something where we can generate how we want each page to look like.

dadleyy commented 8 years ago

nope. I winged it on loftili and it came out alright.

cpb2948 commented 8 years ago

word