badmojr / 1Hosts

World's most advanced DNS filter-/blocklists!
https://o0.pages.dev
Mozilla Public License 2.0
1.56k stars 90 forks source link

False Positive: Ticket shop for holidaypark.de not working #243

Closed d-Rickyy-b closed 3 years ago

d-Rickyy-b commented 3 years ago

Hi, it's me again. Today I found out that the ticket shop for the German amusement park "Holiday Park" is not working, because they host a script for the webshop on googletagmanager.

They even write on their website (translated by Chrome): grafik

But this is not about "outdated" versions. It's just that several filter lists block googletagmanager in general and hence also block there script at.

www.googletagmanager.com/gtm.js?id=GTM-M2XPLS9

grafik (Peter Lowe's Ad and tracking server list, StevenBlack/hosts with the fakenews and gambling extensions, and this list, 1Hosts (Pro)).

But apart from that, some block lists also block another script file:

www.holidaypark.de/sites/default/files/public/google_tag/google_tag.script.js?qxo8te

I'm not sure if you want to fix this behaviour. I just wanted to report and let other people know how to fix this issue.


The workaround I implemented locally:

@@||www.holidaypark.de/sites/default/files/public/google_tag/google_tag.script.js?qxo8te$script,domain=www.holidaypark.de
@@||www.googletagmanager.com/gtm.js?id=GTM-M2XPLS9$script,domain=www.holidaypark.de

Cheers!

badmojr commented 3 years ago

Can't reproduce! Please provide a link to the mentioned broken page.

d-Rickyy-b commented 3 years ago

URL: https://www.holidaypark.de/de

Firefox with uBlock & 1Hosts: grafik

Edge without uBlock: grafik

badmojr commented 3 years ago

Got it! Related: https://github.com/uBlockOrigin/uAssets/issues/9368, https://github.com/uBlockOrigin/uAssets/issues/8918, https://github.com/AdguardTeam/AdguardFilters/issues/69692

Unfortunately, we only maintain dns/network blocking filters. Removing the GTM entry, especially from 1Hosts (Pro) is a bad idea. I recommend that manual removal be undertaken. Sorry!

d-Rickyy-b commented 3 years ago

No need to be sorry! I already assumed that adding exceptions for things such as GTM would be hard. At least we got it documented here for people googling for it. Thank you!