feat(cross-platform): port home directory and tabbing to linux/mac friendly options

badmotorfinger / z

Save time typing out directory paths in PowerShell by jumping around instead.

The Unlicense

434 stars 33 forks source link

Closed joejag closed 4 years ago

joejag commented 4 years ago

This addresses #44 and allows z to be used on Linux and Macs as well as Windows.

The three cross-platform bugs were:

$Env.USERPROFILE isn't cross-platform, $Env.HOME is
The Get-DirectoryEntryMatchPredicate function looks for multiple drive names, on Linux/Mac this is only / which needs escaping to be used correctly as a regular expression
$function:tabexpansion2 was expecting an extra carriage return in the existing function which doesn't exist on Mac/Linux and was blanking the whole of $function:tabexpansion2

Thanks again for writing this plugin, it's great to have z! Joe.

joejag commented 4 years ago

Thanks for merging @vincpa!

badmotorfinger commented 4 years ago

@joejag Thanks for working on this to make it compatible with *nix based systems :)

I've made a slight change in how the home directory is retrieved on windows and committed this to master.

Can you please verify all is working on Mac?

joejag commented 4 years ago

@vincpa Just tested with rev f8675c3 on master and all working good with your modification included on Linux (so safe to say Mac works as well)

badmotorfinger commented 4 years ago

Great. I'll create an updated package in the next day or two for the PowerShell gallery so it's available to everyone.

Thanks again for this.

badmotorfinger commented 4 years ago

joejag commented 4 years ago

Installed and tested, all good. An aesthetically pleasing version number too. Thanks!