search

badoo / Chateau

Chateau is a framework for adding (or improving) chat functionality in any Android app
MIT License
664 stars 93 forks source link

Constants for Groovy code #6

Open bkodirov opened 8 years ago

bkodirov commented 8 years ago

I believe if you use constants in your gradle scripts instead of this

compile 'com.android.support:appcompat-v7:23.1.1' compile 'com.android.support:recyclerview-v7:23.1.1'

Build script would be less error prone. You can store them in the gradle.properties file for example And use like below

compile "com.android.support:recyclerview-v7:$depAndroidSupportVersion" compile "com.android.support:design:$depAndroidSupportVersion" compile "com.android.support:recyclerview-v7:$depAndroidSupportVersion" compile "com.android.support:cardview-v7:$depAndroidSupportVersion"

kingamajick commented 8 years ago

Hi, this is something we may look at as part of improving the build system, but we'd want to bring it in line with what were doing in internally. I can certainly see advantages of taking this approach.