Fix BaseFeature serialisation behaviour regression

badoo / MVICore

MVI framework with events, time-travel, and more

https://badoo.github.io/MVICore/

Other

1.27k stars 90 forks source link

Fix BaseFeature serialisation behaviour regression #167

Closed LachlanMcKee closed 2 years ago

LachlanMcKee commented 2 years ago

The BaseFeature has a regression related to ordering when using a PostProcessor.

The behaviour previously (which is potentially a bug) would cause the PostProcessor to change the order of news events.

This change should be reverted (to avoid bugs), but also made configurable if that is the desired behaviour.

LachlanMcKee commented 2 years ago

After further investigation it turns out that this regression actually fixed an outstanding bug in MVICore. However for now until we update to a later version of Kotlin (due to the approach I will take to approach this fix), I will revert the change.

If you use a featureScheduler the behaviour change will be introduced, so it is a 'gotcha' for now. I will raise a new PR in the following days to make this behaviour fix opt-in