badoo / MVIKotlin

Extendable MVI framework for Kotlin Multiplatform with powerful debugging tools (logging and time travel), inspired by Badoo MVICore library
https://arkivanov.github.io/MVIKotlin
Apache License 2.0
828 stars 64 forks source link

Adding dependency on mvikotlin 2.0.1 in a multiplatform project, there is a gradle error about samplesources #200

Closed mikezliu closed 3 years ago

mikezliu commented 3 years ago

When adding a gradle dependency to mvikotlin in my multiplatform's commonMain sourceset, I am getting a build error. If I add the dependency in my android app's build gradle file, I'm not seeing an error (so it seems to not be a jcenter issue). It seems to be searching for samplesources when I include the dependency in my multiplatform project.

implementation "com.arkivanov.mvikotlin:mvikotlin:2.0.1"

Gradle import errors/Users/user/repos/app/client/client-shared/build.gradleproject ':appKotlinShared': Unable to build Kotlin project configurationDetails: org.gradle.internal.resolve.ArtifactNotFoundException: Could not find mvikotlin-2.0.1-samplessources.jar (com.arkivanov.mvikotlin:mvikotlin:2.0.1).Searched in the following locations: https://jcenter.bintray.com/com/arkivanov/mvikotlin/mvikotlin/2.0.1/mvikotlin-2.0.1-samplessources.jar
arkivanov commented 3 years ago

Hi. What targets do you support? Looks like your issue is answered here: https://stackoverflow.com/questions/65892546/gradle-doesnt-look-for-dependency-in-the-right-way

mikezliu commented 3 years ago

I'm currently supporting these targets in my multiplatform project:

commonMain, jvmMain, iosMain, iosArm32Main, iosArm64Main

commonTest, iosArm32Test, iosArm64Test

Thanks for the link - taking a look

arkivanov commented 3 years ago

As written in the readme, only the following targets are currently supported: Android, JVM, JavaScript, iosX64, iosArm64, macosX64, linuxX64

mikezliu commented 3 years ago

Got it, thanks