Can't export time travel data

badoo / MVIKotlin

Extendable MVI framework for Kotlin Multiplatform with powerful debugging tools (logging and time travel), inspired by Badoo MVICore library

https://arkivanov.github.io/MVIKotlin

Apache License 2.0

828 stars 64 forks source link

Can't export time travel data #267

Closed falcon4ever closed 3 years ago

falcon4ever commented 3 years ago

It looks like the export option for time travel data is not working correctly. I was trying out the time travel feature using the TodoApp project and the export button does not open up a dialog on where to save the data. See recording: https://youtu.be/vVxzPba4078

Dev Environment:

Mac OS X Catalina 10.15.7
Android Studio Arctic Fox 2020.3.1 Beta 5
MVIKotlin Time Travel Plugin v2.0.0
Decompose v0.2.6
MVIKotlin v2.0.4

arkivanov commented 3 years ago

Hello @falcon4ever . I think this question is more relevant to MVIKotlin than Decompose, so transferred it.

The export/import feature currently only works for JVM and Android, and requires States, Intents, Labels, Actions and Results to be Serializable. The latter is not the case for the TodoApp example in the compose-jb repository. You can try the similar todo app example in this MVIKotlin repository, it should work fine.

I think we should explicitly mention this requirement in the docs, so I will keep this issue open. Probably some meaningful errors would be also helpful.

falcon4ever commented 3 years ago

Apologies, having both projects opened in the browser and I posted in the wrong one 🤦‍♂️ thanks for moving it.

Ah, thanks for the explanation! Will try out your suggestion

arkivanov commented 3 years ago

Closing for now, feel free to reopen if there are still any issues.