Closed ema987 closed 2 years ago
Thank you very much for the fix! Seems like on macOS the file name filter is ignored and you can actually select any file. On Ubuntu (my machine) it works fine and allows only adb
files to be selected.
Thank you for the fast response! The code should now be fixed as you asked
Thanks for your contribution!
First of all, thank you very much for this amazing project!
Issue description:
adb
adb
) ending in an error.Now you can't anymore select the right
adb
executable and you're stuck with an unusable app/plugin.It looks like to me the right checks are in place to avoid select an executable which is not
adb
in the file selection dialogs but the filters/checks are not respected, at least on my Macbook with BigSur 11.4 and IntelliJIdea plugin version 3.0.0-alpha01.I improved the
adb
path selection manually checking a file namedadb
is selected in the file selection dialog. Furthermore, everytime you start debugging, the code checks the selected path is anadb
executable, otherwise it prompts you the file selection dialog.This is a quick fix and unfortunately duplicated in some places.
IMHO, in a future version, it would be better to create a new button to make the user able to select the
adb
path anytime, so it can be changed when needed and some checks can be removed.I hope this is useful!