search

badoo / RIBs

Badoo's take on RIBs
Apache License 2.0
162 stars 50 forks source link

RIB fragment #237

Closed CherryPerry closed 3 years ago

CherryPerry commented 3 years ago

After some additional investigations, I discovered, that using isFinishing flag combinations for fragment still has issues. ViewModel is only option for fragments. I decided to use ViewModel in activities too to have consistent behaviour.

Depends on https://github.com/badoo/RIBs/pull/235

CherryPerry commented 3 years ago

Some tests?

CherryPerry commented 3 years ago

https://github.com/badoo/RIBs/issues/246

CherryPerry commented 3 years ago

@zsoltk ready to review and merge.