search

badoo / RIBs

Badoo's take on RIBs
Apache License 2.0
162 stars 50 forks source link

Rib ComposeView approach #339

Closed SamuPS closed 3 years ago

SamuPS commented 3 years ago

Internal visibility modifier for view var in Node removed to access view from ComposeRibView. This could be avoided by merging packages, tough not sure if desirable.

SamuPS commented 3 years ago

Please take a look to the targetFactory in ComposeView. It was added to allow custom Viewgroup for children placeholder in the target(e.g change layout params). But this could probably be solved in the parent view(e.g defining box size) so default match parent for the FrameLayout will be ok. So should we keep the targetFactory, or do you think that it wouldn't be required so we can simplify code and make ComposeTarget internal?