search

badoo / RIBs

Badoo's take on RIBs
Apache License 2.0
162 stars 50 forks source link

Migrate to extracted customisation #358

Closed KovalevAndrey closed 2 years ago

KovalevAndrey commented 2 years ago

Description:

  1. Customisations have been extracted to a separate repository in order to be shared between 2 RIBs frameworks
  2. In this PR we migrate to common customisations
  3. Note, that targetSdk in app-utils-tree repository matches main project (31) while RIBs repository targets 30.
  4. targetSdk has been increated to 31. Android projects which target 31+ must set exported = true attribute for Launcher activities in Manifest. This project uses LeakCanaryActivity which does not have this attribute set in the 2.4 version so I updated it to the latest one
  5. In order to target 31 sdk robolectric needed to be updated along with kotlin mockito and compose. Note, that kotlin mockito has been upgraded to 3.2.0 which does not contain any API changes.

Related issue(s):

CherryPerry commented 2 years ago

We also have RibsViewActivity and RibsViewActivity that probably should also have exported declarations (false too).

CherryPerry commented 2 years ago

Much cleaner with typealias now 👍