search

badoo / Reaktive

Kotlin multi-platform implementation of Reactive Extensions
Apache License 2.0
1.18k stars 58 forks source link

[2.0] Kotlin 1.8.21 and new source set layout #752

Closed arkivanov closed 1 year ago

arkivanov commented 1 year ago

Also updated coroutines to 1.7.1 and removed @OptIn(ExperimentalCoroutinesApi) annotation from runTest.

Closes #749.

CherryPerry commented 1 year ago

You have removed AndroidManifest.xml but have not added 

android {
    namespace = "com.badoo.reaktive.annotations"
}

to build files, so I am kinda worried about namespace that is used right now for .aar files. Can you added it please then? It is part of migration to AGP 8+ too.

arkivanov commented 1 year ago

I moved manifests to androidMain, as specified in the docs. I will update the PR with namespace.

arkivanov commented 1 year ago

I moved manifests to androidMain, as specified in the docs. I will update the PR with namespace.

Updated.