search

badoux / checkmail

Golang package for email validation
MIT License
718 stars 91 forks source link

TestValidateFormat fails in 1.2.3 #39

Open QuLogic opened 3 years ago

QuLogic commented 3 years ago

This used to pass in 1.2.1:

$ go test -run TestValidateFormat
--- FAIL: TestValidateFormat (0.00s)
    checkmail_test.go:94: " florian@carrere.cc" => expected error
    checkmail_test.go:94: "florian@carrere.cc " => expected error
    checkmail_test.go:94: " test@gmail.com" => expected error
FAIL
FAIL    github.com/badoux/checkmail 0.003s
FAIL
QuLogic commented 3 years ago

Bisect says 9c951e8f02db21a69ecc24b9901694dff0e3e0e1 or #31 (but there were many build failures in between, so may or may not be true.)

bensie commented 2 years ago

I'm seeing the same issue - the regexp change causes the failure.

QuLogic commented 9 months ago

Still broken in 1.2.4 as well.