search

badrinarayanan / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

goog.ui.SliderBase leaks #253

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
The problem is in method animatedSetValue_. 

This code needs disposing:
if (this.currentAnimation_) {
    this.currentAnimation_.stop(true);
}

This is fix:
if (this.currentAnimation_) {
    this.currentAnimation_.stop(true);
    this.currentAnimation_.dispose();
}

Original issue reported on code.google.com by steida...@gmail.com on 2 Jan 2011 at 10:23

GoogleCodeExporter commented 8 years ago 
another leaks:
Put this into disposeInternal:
if (this.valueDragger_) this.valueDragger_.dispose();
if (this.extentDragger_) this.extentDragger_.dispose();

Original comment by steida...@gmail.com on 2 Jan 2011 at 1:07

GoogleCodeExporter commented 8 years ago 
 we can make the update.

steida.cz, can you sign the contributor license agreement?

Original comment by nn...@google.com on 27 Apr 2012 at 10:27