badrinathvm / StepperView

SwiftUI iOS component for Step Indications.
https://badrinathvm.github.io/StepperView/
MIT License
1.25k stars 60 forks source link

Center rounded line alignment for StepIndicatorVerticalView #77

Closed rcole34 closed 3 years ago

rcole34 commented 3 years ago

Description

This small change corrects the center-alignment of rounded lines in StepIndicatorVerticalView. Other vertical line types and all horizontal line types have not been tested and may also need a similar fix if they are also subtracting the full width of the line rather than half. Before After
Screen Shot 2021-05-19 at 2 57 45 PM Screen Shot 2021-05-19 at 2 58 52 PM

Type of change

How Has This Been Tested

This has been manually tested for the vertical rounded line type. The code in question is only used for that type of line, so it should not break any other types.

Test Configuration

Checklist:

For checklist items not applicable, mention NA in front of it with some comment if applicable.

badrinathvm commented 3 years ago

Thank you @rcole34 for the contribution and the code looks good for VerticalView also validated the horizontal one no changes are required for it as it is already midY ( https://github.com/badrinathvm/StepperView/blob/master/Sources/StepperView/Views/StepIndicatorHorizontalView.swift#L144 )