search

badstreff / git2jss

Easily sync your scripts and EA's from a git repo with the JSS
MIT License
89 stars 56 forks source link

gitignore file, stricter shebang matching, updated read me #27

Closed homebysix closed 5 years ago

badstreff commented 5 years ago

I like this for my personal dev purposes, it might cause confusion for people that are forking the project to their internal repos and then doing a git push. I think we will probably want to update the README to clarify if they want to push scripts to another repo they will need to edit the .gitignore.

homebysix commented 5 years ago

If people are forking the project to their internal repos, they'll already need to know how to handle multiple remotes in order to continue getting the latest changes from upstream.

Would it be better to add the ability to download extension attributes and scripts to a location outside the repo? If so, I can work on that.

badstreff commented 5 years ago

I can agree with that first statement, I think long term Brad and I have both tossed around the idea of specifying an alternative location for scripts but I don't think we need to hold this PR up for it.