search

baduhai / Koi

Koi - Theme scheduling for the KDE Plasma Desktop
GNU Lesser General Public License v3.0
270 stars 20 forks source link

Fix KDE/GTK missing themes #57

Closed RodoMa92 closed 2 years ago

RodoMa92 commented 2 years ago

If the name of the themes precedes Breeze, it now doesen't cut out the first two entries. (maybe because it was originally skipping . and .. before calling the API with QDir::NoDotAndDotDot?).

baduhai commented 2 years ago

Does the breeze plasma style still show up without the plasmaStyles.append("breeze"); line?

RodoMa92 commented 2 years ago

You are right, breeze has disappeared, whoops. Reverted that line.

baduhai commented 2 years ago

Thanks for the fix, I totally missed the bug.

RodoMa92 commented 2 years ago

Thanks for the fix, I totally missed the bug.

No problem, besides my confusion for why it wasn't working initially, the fix was quite easy. It has taken quite a bit of time to go read the source code, but whatever. It happens.

Thanks a lot for your software, by the way. I hope that Plasma will integrate this in their desktop sooner or later, but your software is working great in the meantime :P

Marco

baduhai commented 2 years ago

Thanks a lot for your software, by the way. I hope that Plasma will integrate this in their desktop sooner or later, but your software is working great in the meantime :P

I'm actually trying to develop this functionality, but reading through and understanding all sections of the Plasma codebase is quite difficult...

baduhai commented 2 years ago

Just did some more testing, and it looks like you were accidentally correct. The plasmaStyles.append("breeze"); line is no longer necessary. Breeze shows up under the name "default", but it shows up. I'll see if I replace the string for the name, or if I leave it as default, but the next release will no longer have the line you accidentally deleted :)