search

baduhai / Koi

Koi - Theme scheduling for the KDE Plasma Desktop
GNU Lesser General Public License v3.0
269 stars 20 forks source link

[OTHER] Packaging guidelines #77

Closed michalszmidt closed 11 months ago

michalszmidt commented 11 months ago

Hi,

thank you for developing this missing piece of KDE!

As a packager I could not create template file for Koi for Void Linux build system. It doesn't recognize it as a cmake project. I could not find any workaround for it except forking repo and setting src as top root of the project

I'm not expert but most cmake projects I saw had CMakeLists.txt in the root of the project. I guess this should fix it.

Could you tweak and move CMakeLists.txt to the top root of the project then create a tag 0.2.4.1?

Also I opened https://github.com/void-linux/void-packages/issues/47761 so they could handle this scenario.

MartinVonReichenberg commented 11 months ago

Hello,

cmake -S ${srcdir}(name-version)/src/ -B ${builddir}/src/build/

Look at the AUR PKGBUILD file, it should be the same . . .

MartinVonReichenberg commented 11 months ago

So, Did you succeed at Issue#47761 , @michalszmidt ?_?

michalszmidt commented 11 months ago

EDIT:

It turned out that my test environment was weirdly broken and with help of void-linux team compilation passes now.

I'll tweak it more (add desktop files etc.) and open pull request for Koi to the official void repo! Thanks for your time.

MartinVonReichenberg commented 11 months ago

EDIT:

It turned out that my test environment was weirdly broken and with help of void-linux team compilation passes now.

I'll tweak it more (add desktop files etc.) and open pull request for Koi to the official void repo! Thanks for your time.

What desktop files?

All is mentioned in Koi/src/resources/(resources.qrc) and there is already a koi.desktop file inside Koi/src.

michalszmidt commented 11 months ago

What desktop files?

All is mentioned in Koi/src/resources/(resources.qrc) and there is already a koi.desktop file inside Koi/src.

Right. Everything is there.

Finally submitted https://github.com/void-linux/void-packages/pull/47985 PR