search

baduhai / Koi

Koi - Theme scheduling for the KDE Plasma Desktop
GNU Lesser General Public License v3.0
270 stars 20 forks source link

Patch to add wheel click toggle #86

Closed financelurker closed 5 months ago

financelurker commented 5 months ago

This is a continuation of https://github.com/baduhai/Koi/pull/72 and resolves https://github.com/baduhai/Koi/issues/84

Another try, since on my machine there is no more wayland error (was it probably fixed upstream within KDE in one of the intermediate updates? or due to https://github.com/baduhai/Koi/pull/83 ? )...

Also, extended the call of QSettings->setValue with .toString() to get rid of QVariant errors when reading back the settings.

Machine Setup, where this works:

Operating System: EndeavourOS 
KDE Plasma Version: 6.0.5
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.1
Kernel Version: 6.9.4-zen1-1-zen (64-bit)
Graphics Platform: Wayland
Processors: 32 × AMD Ryzen 9 7950X 16-Core Processor
Memory: 93,5 GiB of RAM
Graphics Processor: NVIDIA GeForce RTX 4090/PCIe/SSE2
Manufacturer: ASUS

Tho, it needs to be mentioned: There is one caveat to this solution... If the user switches the mode without Koi the stored value in the current setting gets out of sync with the actual theme/... A solution to this is to actively set a mode from the Koi context menu, then the current setting is again aligned.

Thanks to @nmrkr for the initial code.

financelurker commented 5 months ago

And just for the record: On my local machine, when testing that build (starting app, switching themes, etc.) the console stays clean and no errors or other annoying logs are shown (as it was the case in the other merge-request).

I am curious if this is also the case now on your setup @MartinVonReichenberg ?

MartinVonReichenberg commented 5 months ago

And just for the record: On my local machine, when testing that build (starting app, switching themes, etc.) the console stays clean and no errors or other annoying logs are shown (as it was the case in the other merge-request).

I am curious if this is also the case now on your setup @MartinVonReichenberg ?

That is why it needs to be tested across various Linux distributions.

I shall take a look at it later . . .

financelurker commented 5 months ago

No worries. I only wanted your attention, just so I know that it is on your radar (and because I have seen that you've been involved in the previous PR). For now I can live with my custom build anyways 👌🏻 Looking forward how this change will behave on other distros and if there potentially are troubles reported.