search

badvision / lawless-legends

Open-source code and assets from Lawless Legends and its supporting tools
Apache License 2.0
67 stars 15 forks source link

minor size optimisations #19

Closed peterferrie closed 8 years ago

peterferrie commented 8 years ago

note that fontengine.s!Wp_CFnt has a bad compare

badvision commented 8 years ago

Many thanks for this! :) We'll have a look and do some testing.

peterferrie commented 8 years ago

Many thanks for this! :) We'll have a look and do some testing.

One correction to my submission: fontengine.s, line 252: "bne" should say "bcc"

badvision commented 8 years ago

If you revise your commit it should update the pull request automatically. (In theory)

On Tue, Apr 19, 2016 at 10:44 AM Peter Ferrie notifications@github.com wrote:

Many thanks for this! :) We'll have a look and do some testing.

One correction to my submission: fontengine.s, line 252: "bne" should say "bcc"

— You are receiving this because you commented.

Reply to this email directly or view it on GitHub https://github.com/badvision/lawless-legends/pull/19#issuecomment-211986972

peterferrie commented 8 years ago

If you revise your commit it should update the pull request automatically. (In theory)

Right, "in theory", but it seems to have worked.

martinhaye commented 8 years ago

Tested and everything seems to work properly now. And, it's just a little bit smaller :) Merged to master.

Thanks so much for your careful work on this!

peterferrie commented 8 years ago

fontengine.s!Wp_CFnt: AND #$03 ;mask off digit CMP #4 BEQ Wp_CfDn

the branch can never be taken. The whole routine is currently a nop, but still...