Disallow/warn/convert smart quote characters?

badvision / lawless-legends

Open-source code and assets from Lawless Legends and its supporting tools

Apache License 2.0

67 stars 15 forks source link

Disallow/warn/convert smart quote characters? #23

Open andrewschultz opened 7 years ago

andrewschultz commented 7 years ago

Test case:

New game
Enter cheat mode
3-d mode = 1, map 15, go to (5,9) and go forward

"Don Orolarge" appears instead of "Don Oro's large" and this is because there are multi-byte smart quotes in the XML file that an 8-bit computer was never meant to process. These are not easy to notice, so I wonder if the editor can/should check for the 0x201(8/9/c/d) hex characters.

So I guess there are three options as in the title.

badvision commented 7 years ago

Convert makes the most sense. I'll keep this on my radar. Thanks!