search

baedert / corebird

Native Gtk+ Twitter Client
https://corebird.baedert.org
GNU General Public License v3.0
791 stars 78 forks source link

conversation order is wrong if the initial tweet is a retweet #752

Open baedert opened 7 years ago

baedert commented 7 years ago

For example: https://paste.xinu.at/p1H3i/

The retweet that is the topmost tweet in the lower list box should actually be at the bottom.

baedert commented 7 years ago

Okay the screenshot is gone and I can't reproduce the issue right now at all.

Vistaus commented 7 years ago

I can't reproduce this issue either.

baedert commented 7 years ago

Let's just close it for now.

baedert commented 7 years ago

Proof that this is a thing: https://my.mixtape.moe/fvwzje.webm

Just need to find time now to find out what's wrong + fix.

baedert commented 7 years ago

Heh. It's actually all technically correct. This problem happens when the three tweets are created in the following order: 1) The actual tweet 2) The reply to 1) 3) The retweet of 1)

Now, the TweetInfoPage will show the replies to the original tweet, i.e. 1) and not to the retweet. However, when both 2) and 3) are in the lower listbox together, the underlying model will sort them after their source ID (which is what makes sense in the home timeline, basically) and so the newer retweet will be on top and the older reply will be at the bottom.