Closed IBBoard closed 7 years ago
Example logging for good and bad thread creation - note the difference at DMThreadsModel.vala
line 63.
I've got a fix for this, but I don't know whether it is better to do more extensive changes (pull out the right info earlier and change the whole function) or make smaller changes (three lines commented out in my logging diff in the DMThread
creation section, which include a couple of ternaries)
Isn't https://github.com/baedert/corebird/commit/6e6777e680fc9ec93263496839183a328ec0ea3c supposed to fix that?
Don't think so - that's about duplicates with self-replies. This is about starting new threads and using the wrong details to create the thread.
In the latest Git Master, if you send the first DM to a recipient then Corebird gets the threading wrong and creates a thread for you (which is then empty).
Steps to recreate:
Expected result:
Actual result:
If you don't have a cooperative friend to test this with, create a test account. After testing once, you'll need to delete the DMs from your account on Twitter and then open the sqlite database and delete all
dm_threads
rows where theuser_id
is your ID or their ID, and all of thedm
rows wherefrom_id
orto_id
is their ID.After logging and debugging the problem, I found that the problem is in DMManager.vala ~L199 - it correctly detects the
thread_user_id
but then just creates aDMThread
object using the sender's ID. When you create the thread by sending the first DM then the sender us you!