Closed IBBoard closed 6 years ago
libtweetlength has its own repo, this is just a copy-in import. I've already made some changes there though.
Ah, okay. I'd assumed external libraries would be a sub-module.
The long list of TLDs should fix the ".uk" situation, but the space issue that I fixed at the same time is still there.
Is it possible to generate that list automatically from the Twitter source (e.g. the YAML file), in case they update it in future? And if it is, is it worth putting the script in VCS as well?
But it's still the wrong repo, I can't merge it from here.
The long list of TLDs should fix the ".uk" situation, but the space issue that I fixed at the same time is still there.
The .co.uk bug is still not fixed right now, but I have an attempt locally.
Is it possible to generate that list automatically from the Twitter source (e.g. the YAML file), in case they update it in future? And if it is, is it worth putting the script in VCS as well?
What YAML file? It's really not that important, I doubt anyone will notice it when I remove the .cancerresearch GTLD for example... (I know it since the old list was incomplete.)
This appears to fix Bug #774 for me and revert it to older behaviour: http(s)://anything is a URL, and a select subset of TLDs get picked up without a protocol.
Also includes a minor fix where
http://example.com/[space-character]
was counted as just a URL, not a URL followed by a space.