search

baedert / corebird

Native Gtk+ Twitter Client
https://corebird.baedert.org
GNU General Public License v3.0
791 stars 78 forks source link

Bug774 url length counting fix #775

Closed IBBoard closed 6 years ago

IBBoard commented 6 years ago

This appears to fix Bug #774 for me and revert it to older behaviour: http(s)://anything is a URL, and a select subset of TLDs get picked up without a protocol.

Also includes a minor fix where http://example.com/[space-character] was counted as just a URL, not a URL followed by a space.

baedert commented 6 years ago

libtweetlength has its own repo, this is just a copy-in import. I've already made some changes there though.

IBBoard commented 6 years ago

Ah, okay. I'd assumed external libraries would be a sub-module.

The long list of TLDs should fix the ".uk" situation, but the space issue that I fixed at the same time is still there.

Is it possible to generate that list automatically from the Twitter source (e.g. the YAML file), in case they update it in future? And if it is, is it worth putting the script in VCS as well?

baedert commented 6 years ago

But it's still the wrong repo, I can't merge it from here.

The long list of TLDs should fix the ".uk" situation, but the space issue that I fixed at the same time is still there.

The .co.uk bug is still not fixed right now, but I have an attempt locally.

Is it possible to generate that list automatically from the Twitter source (e.g. the YAML file), in case they update it in future? And if it is, is it worth putting the script in VCS as well?

What YAML file? It's really not that important, I doubt anyone will notice it when I remove the .cancerresearch GTLD for example... (I know it since the old list was incomplete.)

IBBoard commented 6 years ago

I found this YAML in twitter-text, which I'd assumed was your reference.

I'll work on this in the other repo.