search

baedert / corebird

Native Gtk+ Twitter Client
https://corebird.baedert.org
GNU General Public License v3.0
791 stars 78 forks source link

Typing DM causes window to stretch #796

Closed IBBoard closed 6 years ago

IBBoard commented 6 years ago

When typing a tweet, the text wraps as expected in the text box.

When typing a Direct Message, the text just keeps extending the width of the browser and doesn't wrap, even when there are plenty of spaces that it could wrap at. At some arbitrary point (around 50% of my screen size) it stops expanding and starts wrapping for some reason.

As with bug #514, you can't reduce the size of the window. Unlike the other bug, if you manually extend the window when it has hit 50% and wrapped then you can't shrink it again (the previously wrapped text fills the available space on the previous line and then won't wrap back again).

Deleting text so when you've extended the window over 50% width causes the window to shrink its width by itself (back to 50% but no smaller, even if more text is deleted).

This doesn't affect DMs in the list, only typing them.

This could be related to the Pango wrapping change.

Version: fdd81f86a1f24ebb90ef7dae2952c2bd0cb32dc8 OS: openSUSE Tumbleweed GTK: 3.22.25 Pango: 1.40.13

baedert commented 6 years ago

Sounds like it's just https://bugzilla.gnome.org/show_bug.cgi?id=766822 again (just that the workaround in corebird is gone).

IBBoard commented 6 years ago

Just updated to Pango 1.40.14 and it still happens, but far less than it did. Lots of words with spaces will cause a slight widening if the space lands in the wrong place. A long string of text without spaces eventually wraps in a not-completely-ridiculous way (see this Pango bug for the odd wrapping) but still pushes the window to 50% width.

I guess this is mainly a Pango issue, then.

IBBoard commented 6 years ago

Is the UI part of the long name change necessary?

I've undone it and everything seems to work correctly with wrapping, and name completion (which I hadn't seen before in DMs) still works, even with long names.

ValdikSS commented 6 years ago

I'm using Pango 1.40.14 but it happens to me all the time.

Vistaus commented 6 years ago

Can't reproduce this with Pango 1.41 (current git master). So it might be fixed upstream already.

ValdikSS commented 6 years ago

Just built git master with fedora's 1.40.14-1.fc27 pango. I don't see any commits in pango git master which fix this issue.

Vistaus commented 6 years ago

I'm not talking about Corebird git master, I'm talking about Pango git master which is currently at 1.41 I'm using it and don't notice this issue, whereas I did encounter it with 1.40. So something has fixed it.

ValdikSS commented 6 years ago

Just build pango git master and ran corebird with it (made sure that git master version is used with /proc/PID/maps path) and still have this issue.

Vistaus commented 6 years ago

Hmm, seems to be a hit or miss then...

ValdikSS commented 6 years ago

It used to be fine on Fedora 25 (with corebird git master), but not on Fedora 27, to which I switched only a week ago.

ValdikSS commented 6 years ago

@baedert, is it possible to add workaround again until it's fixed in upstream?