search

baedert / corebird

Native Gtk+ Twitter Client
https://corebird.baedert.org
GNU General Public License v3.0
792 stars 78 forks source link

[next2] What needs reporting? #804

Open Vistaus opened 6 years ago

Vistaus commented 6 years ago

So as I said yesterday, I'm now on the next2 branch to help out with testing. But I'm wondering: is there a list or somewhere of features not yet re-implemented? 'Cause I do notice a few non-working features and I'm wondering if that's because they're not re-implemented yet or because of a bug or something.

baedert commented 6 years ago

Depends. Some things are broken in gtk, some in Corebird. Now and then there's a warning printed on the console when I commented something out. You can just post everything you notice in this bug.

Off the top of my head I know of:

Vistaus commented 6 years ago

Thanks. I'll report everything I come across then. I did notice the stuff you mention. On top of that, the Settings window is empty so I guess that also needs to be re-implemented still?

baedert commented 6 years ago

No the settings window is basically unchanged (apart from some css problems in the snippets page) and that should be fixed by https://github.com/baedert/corebird/commit/e4bd42228ed03993517465ec57364bfd31da3758

Vistaus commented 6 years ago

Hmm, well the settings window wasn't working for me but it is working now after pulling the latest commits :)

Vistaus commented 6 years ago

Right-click on media works now with the latest vala and corebird next2 commits :)

Vistaus commented 6 years ago

Found another one:

I can click the person who posted the tweet, but not the person who retweeted it. Works fine on master though.

baedert commented 6 years ago

Should work now, thanks.

Vistaus commented 6 years ago

You're welcome! And thank you for fixing it so quickly, I can confirm that it works now! :)

Vistaus commented 6 years ago

I just noticed Ctrl+Enter to send a DM (or reply in a DM conversation) doesn't work on next2.

Vistaus commented 6 years ago

I just noticed Ctrl+Enter to send a DM (or reply in a DM conversation) doesn't work on next2.

Working fine now :) Thanks to commit https://github.com/baedert/corebird/commit/c7b3e440c25ae5c855c37cc18b5b4961140d356b

Vistaus commented 6 years ago

I noticed another little thingy: when you click on a DM conversation with new messages, it takes you to the top (i.e. the start) of the conversation rather than the bottom where the newest message is.

Vistaus commented 6 years ago

Fixed by https://github.com/baedert/corebird/commit/bc856b76243e62082dee9467af47f9510021f4e2, thank you! :)

Small request: could this be ported to the next2 branch as well? https://github.com/baedert/corebird/commit/87bc8519968ed8f4ab044afaa09d9f9cefd7f6ea

baedert commented 6 years ago

It's already in next2: https://github.com/baedert/corebird/blob/next2/src/CbTextView.c#L663 it's just never enabled because gspell depends on gtk3 so we can't use it right now.

Vistaus commented 6 years ago

Ah, I understand. Thanks.

Vistaus commented 6 years ago

Sending tweets seems to be broken in next2:

─vistaus@solus /run/media/vistaus/MicroSD/Apps  ‹system› 
╰─$ corebird

(corebird:7030): Gtk-WARNING **: Locale not supported by C library.
        Using the fallback 'C' locale.
(corebird:7030): corebird-DEBUG: Corebird.vala:210: startup
(corebird:7030): corebird-DEBUG: Creating stream for Motionshot
(corebird:7030): corebird-DEBUG: 0 Starting stream for Motionshot
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=45211404&skip_status=true
(corebird:7030): corebird-DEBUG: REST: GET 1.1/friendships/no_retweets/ids.json
(corebird:7030): corebird-DEBUG: REST: GET 1.1/blocks/ids.json
(corebird:7030): corebird-DEBUG: REST: GET 1.1/mutes/users/ids.json
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=72915446&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=2514473031&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=10340482&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=3752344947&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=86293774&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=762271828412735489&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=1976832967&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=138062686&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=139104301&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=45211404&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/users/show.json?user_id=2249840436&include_entities=false
(corebird:7030): corebird-DEBUG: REST: GET 1.1/statuses/home_timeline.json?count=28&max_id=9223372036854775806&tweet_mode=extended&include_my_retweet=true&contributor_details=true
(corebird:7030): corebird-DEBUG: MainWindow.vala:60: Focus widget now: BadgeRadioButton 0x12c1800
(corebird:7030): corebird-DEBUG: Account.vala:520: Add 92 disabled_rts ids
Message with type 6 on stream @Motionshot
{"friends":[87459327,19748674,537461600,4808588599,21237045,7057242,3195155163,125508939,22209176,3630172590,9794112,47264317,619087323,559046997,736127754,19103267,52813219,172015735,82872090,351928453,1345338582,710963455,104263696,474956866,79287832,1300678026,282640131,325451342,1762277454,99181049,367022893,66379182,2509941978,133395649,140085904,759617030,24161608,316413258,754782817528274945,291387955,610567805,49423975,78279641,102428225,123439437,127217562,2685230728,3127512208,493151641,610415464,261546340,842130539561771010,183600972,121372044,109637687,80048871,153008645,164984815,23735316,2189108480,2644673099,72915446,4124327447,125584981,108444561,485911261,3226541449,40001830,68915519,603526248,87410594,1170587911,140937502,1462903532,1367762701,2952458132,1488219720,874100826,930369026,272308878,19584902,3247558616,928495940,1791747254,740109097,3099748102,952609861,776064242076221440,68819587,1679071,2721673252,2480951,88670422,1915268126,734177453124550656,35544410,211753541,59110484,300721417,871619906,209019665,820695082764566528,334047733,22863492,196341171,17051356,233269066,205286502,702465422,4141643893,2324319948,168182324,224095255,3692967920,350654924,750046876242702336,1072988221,207440475,25812913,11276612,322165546,108991929,1560491976,18159605,16735219,209509760,25492883,3363120033,25870048,80330533,3436419395,19871320,448263198,85005387,314736604,90420314,184723304,710652698945830912,93228690,3785083582,4043893096,17602896,2517187819,2996176443,25521487,31180803,15460081,14265652,89018574,2256506928,531327516,14874480,2469716723,21024630,498831080,18666797,358676626,41259253,230139855,144271076,183992483,1049911748,287018861,311533251,37405956,739498146,265699905,817154650168238081,110783489,3676784482,94490465,462253520,29957069,623584562,47579470,5392522,1067921101,216776631,315799759,212609751,456263529,1535483540,783475549247332353,4711633315,605805760,216707460,16243030,23511544,1520364522,14504859,209511691,35695590,800531356312694785,151694791,179121328,594617548,51649668,121685146,330600099,735046825376239616,1100713562,355769089,634111585,228394614,2436714972,2257188893,455224766,863342437,2686009322,95580785,777538430,1072194104,94129050,2835928276,167652731,867049935501393921,150623125,459242556,168802958,1002407744,436156554,1729124970,215988567,457013516,1403950232,2414834689,204677745,2427548436,896494154,2607871394,22080646,246142800,18945401,15846407,3598857262,3328063299,20292908,86419569,18488281,585224669,84351228,2877682863,2434793264,23327415,236617121,83315180,40675067,420673339,1575163778,735714193,456901717,157962084,2926866358,2877754364,18503906,285009849,76616401,452267695,2364696639,3780634108,113675550,2571874074,2182183370,225785662,396787001,316285143,395314447,2341948145,765515832,554818467,910501441466494979,2676205874,285428413,17865082,593425336,807302788350955520,287580365,14357338,3060963157,297502836,550172711,38143533,940835701,24839918,23577041,601031991,171593052,434717685,1523689844,795769780426960896,130357453,165056930,121383164,463795123,174253606,1338642062,2553151,2015001,228104454,14822382,242349175,343382976,63546550,958683282,118119034,211078738,23287527,2932821,1016021178,318031893,188977166,28521141,566672898,548411276,1451086405,2634276141,490643767,822558895424110592,1652460752,17344075,67242892,958192616,18044782,10340482,771046078238121984,701085355559276545,441811433,339833310,81871749,2570274238,220912037,2822530175,124427787,474943716,189305014,2764230453,770610080,2525444534,65736065,825170533272674304,1231183957,2566003597,153316396,41227463,3046985449,175463998,46598192,155984714,15446648,747544149889515520,1102621676,233634021,405131257,193162743,139225800,467179980,256139841,4138024643,939240392,20728709,23784732,198930716,22152275,1019893729,2514473031,1630717304,1973402894,759661297,20082882,833018689,22870584,334200875,3315424375,740908202175438848,186780513,624953558,367703310,19591113,2624788232,73620907,1004962819,148104341,121769032,242025573,90438926,43705409,504752691,1241615390,244368081,32619374,3013931015,494452924,360144714,3084079288,551247481,2818627653,28809370,493090150,2445464826,48437084,72554790,1458247532,52676994,302475931,71105268,15518000,356567464,376935331,2869451076,1012353787,235964621,56348005,9130642,143244854,9723672,276460977,2903328279,234907277,21447548,3221307677,52613032,2856469421,551322847,2731469872,307745981,131891655,145946516,2888933834,2478045313,2305624152,2191981764,2294148420,214176174,2178659651,82647069,23873876,1853044236,29804921,358436658,738476560143912960,2294373061,1392754884,4075058369,563323659,274667536,14260234,1975660129,30574459,71580098,265918454,2336654648,42218052,12533432,216341912,139104301,201631025,64349812,11475812,3194722591,381510533,206777606,342017015,30039253,3244043139,87055402,240621015,244243569,2354844056,127234377,1344468948,2922486103,1320264908,2424479150,732058968747466753,805315602,118055879,781730,94204443,2184698187,362708490,54400404,1542904957,311896651,2861118190,86144506,42374737,3300725489,965812124,455497241,171892443,616958743,965778331,47592568,1668126816,180354475,14519643,4840139799,21452249,3559371,87740088,637006509,15898172,228355357,2259099736,18892840,2249840436,42854112,114894699,89869970,723973282538655744,388358277,523042339,1444325670,329017879,3790637297,321304084,62806519,139611310,807095,1378537544,66737320,150791272,90711517,159413309,2969196747,326305429,43887829,38817463,15884517,1469534636,209106263,16036960,863890504328650753,238128989,64857767,151885447,895857630,160817572,14541208,277408484,40722063,11403882,2686379874,57047586,90550015,309701588,2630017334,355737400,3759441,198193404,197264075,39957566,304185486,4862739300,2451497432,84249568,19024295,25593239,130442366,207067943,26182745,78211144,393180526,725390930,114911093,45317491,538242647,1347588096,62207043,1538150509,52437361,73711180,617553115,29739692,876757975297400832,4652868853,34857406,124048189,736255526477156352,2432940896,2885637304,736381610904322048,64757661,739480903,123954416,751148100,537026652,1427443399,15329506,1964461,14696282,1442829552,397455346,109537447,573967511,19279476,2604097444,559948463,183509963,233545401,37627423,258813277,23030879,2911323440,135510915,358315683,522170663,431629103,53156061,617033584,275021277,715506693300494336,532966109,789998293774368768,319632755,2388931039,193885996,58485760,877345650,827325877,180366758,619723441,2241371028,2907391081,60486934,67016993,3379031529,22183684,187920045,595714650,21755824,820003314167332864,122001280,23046181,2913796527,3398368871,189248614,20145970,148728013,813286,145852539,163634787,13201312,2828190381,29574025,57325781,2720675751,926114798,246308415,18768225,19274498,2339606202,709137446,45912281,4179292275,96111708,590094251,334832837,71368856,2749791742,1330582890,14216745,350044843,396086694,18180193,102384558,918201762628210689,1445814601,784899915323478016,900792012,779627,101467282,352102757,866020695704301568,634224375,15485441,2904119576,1657136048,14771198,1329118164,1697465156,15317247,2163299787,16954760,717337139009208320,27849166,113854342,3171192878,18676731,707944984830484483,30031547,38143019,180507931,363189270,7293832,242671121,564098244,24266176,294636000,2255349152,53013374,1472574594,2858347080,516725585,847388408905211904,149505972,943860818,1569181308,147018859,4208880567,243405595,4753404559,3135230019,427569163,706821212891181056,30112129,783214,8633582,3147261431,629006920,2652956292,47593490,781993642223435777,316546095,925194000,250084634,3752344947,5874122,1972799341,25516907,442503611,1100645648,1948887662,853539791727677440,1020816199,606002290,1944656030,1586085878,1427451266,561071344,245714789,19041826,401379197,143227787,15476570,96795310,2670150396,103921824,35701585,29141019,298033265,790889654,248595702,891418651,251687768,132774626,207176719,334441176,16944211,94968455,19721402,29375739,1409322992,13558962,729101677,2823051303,1378862347,1143021806,1599404228,198644497,35761106,44962002,1045703473,213400654,253616392,29498327,476744412,102223883,268929729,967369646,798759050460598272,107238136,1172795293,418372634,45154345,19810490,954427716,3291159581,2339063619,22690948,19584338,825908183390633985,765790546430484482,2163034562,70343345,4011381,48315386,40927713,162332247,196135242,969431474,805415931732262913,279482611,330485164,30614676,25140900,297047872,127882773,12579252,970908438,236623097,235065801,198737126,895736792,1483336969,157445079,259198586,589941440,150751857,834347883260420097,129834485,78644388,209082165,1143068724,2350730738,18088152,4707212214,2791667658,779509639,22138921,233771215,702240282587361281,280949697,343283956,1416140462,743143297,139209137,223384649,209182646,87754354,23926267,245654282,361965946,578088215,1536791610,208206313,783028006709235716,1345492356,80311139,1018659764,2395513090,157957203,29442313,156229445,20354888,149760844,380611799,769628633732374529,26877303,809276814468136961,145767970,3039551092,3293945825,270031340,1976832967,487736815,365232345,364889277,21555790,1382640403,220800988,2973473626,185223798,3254047099,43289545,337334508,106849190,383397851,753367074,739819873,158550133,1907635370,1087002326,3380075206,19035823,25056673,130238521,168616815,26105371,228759572,3342093934,219060435,1903052570,281216661,2895138060,347302142,300506276,18553889,27655610,15473958,826635415255924737,15366798,287094328,180505807,2358200708,18989206,103249012,2323880252,312061539,1531229653,827686171,24367251,493133862,29109211,7103272,1012824523,146179900,46751590,253598634,558461463,52557448,832386509781217280,2896988177,357709147,725325843095015424,802975920604807170,2512778102,574557490,18124815,908264951189344256,294604534,2745340479,38143366,1557483138,194561578,1258398914,571561858,27056606,226690054,19804103,50215547,2447560455,174787184,2315677346,358057529,2464860319,99451820,868647822,166098784,107729712,236502757,510312022,7674802,19656577,128160630,1476662684,114463320,1582853809,137386696,18948541,789616472,15752204,14665541,564919357,1563515534,917325176,734596047071219713,1599031670,397635610,502092379,2505207128,78324268,259381505,2202240636,1638925069,34670660,213399263,141188787,1254205092,329110291,210835456,1898815243,771727335750074368,1841825142,4598752812,243241059,36374099,333431791,74140322,66339576,243442402,3643946892,595514818,1005112154,576226085,85842020,962301049,68788651,947965242,371734256,902552196,29016115,180236348,628658030,2240769222,615224588,104109805,1479208094,2439483712,2383286705,90460357,1516341704,407419803,56852722,297174372,499238848,391704312,39226557,858841261184339971,2164819860,305500072,365938223,6426552,97766708,26509103,14652398,319627546,85047558,2782818027,73236032,1876963256,629642182,49682306,14272198,188434546,2976410875,612043406,2359994606,187861584,596376328,16910193,228469115,110776667,46331700,33854203,2214899129,762124520345964545,2750107268,88406498,1670053932,1510933412,34743251,390231452,103965911,111447107,125635568,771831614,329679589,810424,179928132,43305144,60300247,245746265,3350053720,77842006,260089724,258175608,2379633542,17783001,1672034125,786892853091983360,579485880,116511290,52734226,48599910,18334111,165473487,251250208,87016821,2615309865,2845365036,55719542,31398374,1090141,1146871578,131334821,266727182,11167502,737242038,88688915,840003558,3298548310,204832963,3174575441,834447619,46731405,876901927,2447576555,1589294886,51493070,2151002962,18001717,1306313720,107556834,1642254692,108146158,16929600,16279766,4847976494,1559455831,18643766,176864693,225633398,1468681872,98348790,1345501116,3724664116,413035069,2983768789,35550514,1289681744,358988091,3474760161,2384304864,3431439047,337742891,28074546,1198988510,74694838,870625412,3379062855,46164502,2714243347,177069084,326090532,1060936267,28523549,52110095,153393105,60701466,3314164657,4320626021,17374751,7144422,848541625,349824121,218899577,14402141,2490502941,498258175,493107014,1550803202,756943242231418880,23073053,2888526495,337502808,2936637238,2919197934,297351600,768701160576389120,1563797977,2614181125,1463430044,15390313,46171378,106534143,15162466,523463594,16223628,32399548,55117855,1461514256,101803450,105555355,192823833,14634720,1357776782,245967914,2956662972,2413228944,315806397,14215482,22279603,64220324,864913008,2927176688,721726495404777472]}

(corebird:7030): corebird-DEBUG: Account.vala:414: Adding 1187 friends...
(corebird:7030): corebird-DEBUG: Account.vala:489: Add 562 blocked ids
(corebird:7030): corebird-DEBUG: Account.vala:458: Add 5 muted ids

(corebird:7030): corebird-WARNING **: FavImageView.vala:54: Fix DND stuff
(corebird:7030): corebird-DEBUG: ComposeTweetWindow.vala:71: Focus widget now: GtkTextView 0x1272860

(corebird:7030): corebird-WARNING **: ComposeTweetWindow.vala:157: ESCAPE to close the compose window is broken atm; sort this out once the key event controller stuff lands in gtk+.
(corebird:7030): corebird-DEBUG: '#rtl4'

(corebird:7030): corebird-WARNING **: ComposeTweetWindow.vala:198: DND stuff
(corebird:7030): corebird-DEBUG: ComposeTweetWindow.vala:71: Focus widget now: GtkButton 0x1318de0
(corebird:7030): corebird-DEBUG: ComposeTweetWindow.vala:71: Focus widget now: (null) (nil)
(corebird:7030): corebird-DEBUG: ../src/CbComposeJob.c:412: POST 1.1/statuses/update.json?status=Meestal is Frits Wester erg goed, maar ik vond hem vanavond erg vooringenomen. En dat hoort niet, hij hoort objectief te zijn. #rtl4&auto_populate_reply_metadata=true

(corebird:7030): corebird-WARNING **: Could not send tweet: Forbidden
(corebird:7030): corebird-DEBUG: ComposeTweetWindow.vala:71: Focus widget now: GtkButton 0x1318c50
(corebird:7030): corebird-DEBUG: ComposeTweetWindow.vala:71: Focus widget now: (null) (nil)
(corebird:7030): corebird-DEBUG: MainWindow.vala:60: Focus widget now: GtkButton 0xf34630
(corebird:7030): corebird-DEBUG: 1 Stopping Motionshot's stream
(corebird:7030): corebird-DEBUG: 0 Stopping Motionshot's stream
(corebird:7030): corebird-DEBUG: MainWindow.vala:400: Windows: 1
(corebird:7030): corebird-DEBUG: MainWindow.vala:491: Saving geomentry for Motionshot: 5,5,734,638
(corebird:7030): corebird-DEBUG: MainWindow.vala:60: Focus widget now: (null) (nil)
(corebird:7030): corebird-DEBUG: MediaDownloader shutdown
(corebird:7030): corebird-DEBUG: main.vala:30: Toplevels Left: 2
(corebird:7030): corebird-DEBUG: main.vala:32: Toplevel: GtkWindow
(corebird:7030): corebird-DEBUG: main.vala:32: Toplevel: GtkTooltipWindow
[I] ╭─vistaus@solus /run/media/vistaus/MicroSD/Apps  ‹system› 
╰─$

Or could it be an issue with the Twitter servers?

Update: the tweet was sent after all, but for some reason it took two times and the Compose window never closed.

baedert commented 6 years ago

Yeah, seems like this was a problem on twitter's side, mixed with the bad error reporting when composing tweets.

Vistaus commented 6 years ago

Alright, thanks for the explanation :)