search

baedert / corebird

Native Gtk+ Twitter Client
https://corebird.baedert.org
GNU General Public License v3.0
792 stars 78 forks source link

[Feature] "Dark" theme #815

Closed BloodyIron closed 6 years ago

BloodyIron commented 6 years ago

Any chance we could get a "dark" mode, so we can save our eyeballs from radiation? Seriously though, it would be appreciated. :)

Vistaus commented 6 years ago

You can enable the Dark Theme setting in GNOME Tweak Tool on the Appearance tab.

BloodyIron commented 6 years ago

But I'm not using GNOME, I was hoping for something built-into corebird?

Vistaus commented 6 years ago

GNOME Tweak Tool also works fine outside of GNOME. Most GTK apps have no built-in setting for dark theme as they are controlled by the Dark Theme setting of GNOME Tweak Tool. If you really don't want GNOME Tweak Tool, then you can also use dconf-editor to enable Dark Theme support for GNOME applications.

Edit: @BloodyIron That's the standard way to theme GTK/GNOME applications these days. There used to be a setting in Corebird (but only through dconf-editor) but since it's not the new way of doing it and since it was deprecated anyway, baedert removed it in the next2 branch (which will eventually be merged into master as well): https://github.com/baedert/corebird/commit/a7eb55ccb16c79df98d1b77b0bc95f8497f895a9

mr-blobbyyy commented 6 years ago

The "arc-dark" theme in your appearance settings for your particular distro is your best bet. Just search your favorite repo for arc-theme or arc-gtk-theme, install, and then the dark theme should then be available in your appearance settings.

Vistaus commented 6 years ago

@mr-blobbyyy The best dark theme "bet" is the one the user prefers. Not everyone has the same taste.

baedert commented 6 years ago

The way to get a dark theme is to use a dark theme everywhere. I'm not going to ship an entirely separate dark theme in corebird.

BloodyIron commented 6 years ago

Forcing people to use a dark theme everywhere just so corebird can have a dark theme, is very short sighted. I for one don't want my entire UI to be dark, and I can't fathom why you think that's going to work for everyone else.

Vistaus commented 6 years ago

@BloodyIron It's going to work for everyone else because it already does: iOS, Android, Windows 10... they all have a Dark Theme option which covers the entire UI and most, if not all, apps and except for a couple of Android apps, none of them have the ability to choose b/w a light and dark theme on a per-app basis.

baedert commented 6 years ago

I don't really see what makes a twitter client so special that you'd want it to look different from everything else, or why other applications don't cause any radiation to your eyeballs, but if you really want another theme you can do that for any gtk3 application by simply setting the GTK_THEME environment variable.

Vistaus commented 6 years ago

@baedert I fully agree with you.

dcnblues commented 6 years ago

Yeah, and in the app homepage, if dark themes are available, smart developers will include a screenshot that lets new users know there's an option that won't create a gag reflex. Plenty of new users looking for non wysiwyg interfaces. *edit I can't even adjust the size of the window? I'm out, never mind.