baedert / corebird

Native Gtk+ Twitter Client
https://corebird.baedert.org
GNU General Public License v3.0
792 stars 78 forks source link

[Feature] System tray icon #816

Closed BloodyIron closed 6 years ago

BloodyIron commented 6 years ago

I really would like it if I could get a system tray icon for this app, so I can minimize it to systray and get notifications through the environment. This may be tied to #702 but I am not sure?

baedert commented 6 years ago

Yes it is but a tray icon is not an option, as discussed several times in older tickets.

BloodyIron commented 6 years ago

Yeah, just read #111 and I have to say it's ridiculous this is just being shut down as a concept, but whatever man.

Vistaus commented 6 years ago

@BloodyIron I know you're using a different environment, but keep in mind that Corebird is a GTK app. And there is no system tray anymore in GTK-based desktops (including GNOME) - the tray was removed from GTK some time ago.

BloodyIron commented 6 years ago

Well that's tragic :(

soundgnome commented 6 years ago

Depending on which desktop you're using kdocker may provide a workaround. It's in the Ubuntu repo, probably other distros too. Just tried it on XFCE and seems to work well.

fmneto commented 6 years ago

@Vistaus that's not an excuse. I am using GNOME 3.28 right now and applications do have a tray icon available (see the attached screenshot).

screenshot from 2018-04-23 21-41-22

Vistaus commented 6 years ago

@fmneto But not officially: https://www.omgubuntu.co.uk/2017/09/will-you-miss-gnome-legacy-tray

fmneto commented 6 years ago

@Vistaus still you can't use the "there is no tray" excuse. It's lame. Just admit you don't want to do it.

Hopefully if somebody else does it you'll accept a merge.

Vistaus commented 6 years ago

@fmneto I don't think it's lame. But just a heads-up: I'm not the Corebird dev; @baedert is. But he has already said multiple times that he's not going to implement it, not even if somebody does a PR, and I fully agree with him.

fmneto commented 6 years ago

@Vistaus that's just sad. I really like corebird but my screen is not big enough that I can afford to just leave it open.

Could you post a link to where @baedert said he isn't going to do it and why?

And I didn't mean to imply you're the dev, although it may have looked that way; sorry about that.

Vistaus commented 6 years ago

@fmneto He said so at the top of this thread ( https://github.com/baedert/corebird/issues/816#issuecomment-364140515) But also here: https://github.com/baedert/corebird/issues/111#issuecomment-35016695 And there are a few other tickets on the subject as well where he also said he's not going to implement it.

fmneto commented 6 years ago

@Vistaus thanks for the link. It clarifies the problem, although it does not justify losing an important functionality. It's a big loss and a huge factor against more people choosing to use corebird.

Not to mention that although @baedert expressed to be "hoping for someone to write a shell extension", he also seems to have no intention of making the needed data available for that to work. And that's what I think is lame. I don't know if that has changed since then, but still.

I know this is pretty much a closed topic (at least for the time being), but @baedert, if you are reading this, what would it take for you to change your mind and either implement it or accept a PR for this?

(I don't really expect an answer, I'm just leaving the question here for posterity).

BloodyIron commented 6 years ago

The only tangible reasoning I've been able to gleam from this is...

"From a user perspective it's just very weird that closing the window does not really close the window"

And while it is definitely important to consider UX (User Experience), A LOT, and I really do mean A LOT, of programs already minimize to system tray when closing. It's such a long list I'm not even going to bother making a comprehensive list. But modern tools like Riot, Remmina, STEAM, and so much more already do close to system tray when hitting "x" or "closing" the window.

So the argument that it is bad UX to go to system tray is bunk. Not only that, this can be completely solved by very easy methods, consider a few options...

  1. When you hit X, a dialogue comes up "Minimize or Quit application" (this is how Mumble handles this)
  2. Have a setting that you can toggle the default behaviour between quit/close to system tray

Honestly, in this day and age, we have so many applications open, to expect users to keep yet another application open just to read notifications is unacceptable, and is most certainly far more disruptive to the UX than a program minimizing instead of quitting. It does not look like @baedert has considered the negative implications of not having a system tray icon feature.

I opened this feature request because it is a deal breaker for me. I work on so many different things, expecting me to have yet another window open just to check notifications is such a significant inconvenience, that I just won't use corebird. And clearly I am not the only one.

So, we can remain being ornery about not implementing a system tray feature, or we can explore how that can work in practice (as in, implement a system tray feature).

fmneto commented 6 years ago

@BloodyIron I couldn't have said it any better. As I said I really like corebird. I've been through countless ways of using twitter until I found it and finally considered I was done searching.

This one thing, though, this lack of usability, and upstream's attitude towards it, really ruin it. I'm still using, but i'm on the lookout for a better alternative.

Naturally, it's his program and he can do whatever he wants with it. And since I'm not really much of a programmer myself, I can't just branch it and create a version that behaves like I'd like it to. I could go on and on, but to be honest I've wasted way more time than I would have liked on this discussion.

Vistaus commented 6 years ago

@BloodyIron If your only goal is to receive notifications, then why don't you just run

corebird --start-service

at boot (or after boot, whatever your prefer)?

That way, Corebird only checks for notifications (and display notifications if there are any) in the background without actually opening the window.

BloodyIron commented 6 years ago

@Vistaus because I want more than just only notifications. I want to click on the system tray icon to bring it up, and then minimize it to system tray, just like I do for STEAM, Riot, and so many other tools. What you've proposed addresses only part of my particular functional need.

baedert commented 6 years ago

sigh I'm not gonna read all that.

As long as I'm the only regular developer on this project, I won't support or maintain things I don't regularly use myself. I can't help people if they have problems if I don't use it and I can't test it either. I also clearly stated in the bug report linked above that I have already written tray icon support and subsequently removed it (and I was not drunk or sleepwalking, I swear) 5 years ago so why exactly would I suddenly add it now?

Vistaus commented 6 years ago

@baedert +1

fmneto commented 6 years ago

@baedert Hey man it's you app, do whatever you want with it. We are all here because we like it. I like it a lot. And I would love to see it getting improvements to make it even better. Things that would make using it even more enjoyable.

But, hey, it's your app.

BloodyIron commented 6 years ago

@baedert why even have an "issues" section of github if you're not even going to read what people care about? Seriously, if that's the kind of attitude you're going to take when we bother to put the time into crafting well thought out statements, then you might as well just turn the "issues" section off.

I wrote what I did, because I wanted to share what I functionally care about. It's completely your decision to act on it or not. But if you're not even going to bother READING it, then I'm just going to walk away from this insult. Seriously guy, turn off the issue section if this is how you're going to behave.

baedert commented 6 years ago

I have closed this issue ages ago and said multiple times that why I'm not going to support it (see above). I'm not going to come home and read the 12 comments you three people wrote over a topic I've stopped worrying about years ago. I told you what the problem is, it's understandable and there is no reason to be childish about it. The issue tracker stays open because people also have problems I support and can fix.

BloodyIron commented 6 years ago

I'm not being childish about it, I've spent my time explaining why your perspective is completely the opposite of how system tray functionality works in so many other applications (namely, the significant majority). Again, if you don't want to hear what people have to say about Corebird, then turn the issue section off. I don't care if you closed the issue.

Whatever man, you want to be an ignoramus about this and literally ignore what people have to say about corebird, then so be it. I'm done here, you clearly have zero interest in actually having a discussion about this, and that's wilful ignorance. This is the kind of pig-headed attitude that has always poisoned the open source community, and I'm glad I don't have to work with you.

Vistaus commented 6 years ago

@BloodyIron He has already discussed this in other tickets. There's no need for him to keep discussing it endlessly. That time is better spent on other things, like developing Corebird, GTK and his personal life :)

baedert commented 6 years ago

Do you really not get it? This has nothing to do with you or what you want or how you use software. It's about software maintenance, support and testing. I can't test, support or maintain this feature, end of story.

metal3d commented 6 years ago

Sorry to say that but I don't have any tray icon for CoreBird, using Fedora 27/28, Gnome, and so on... all other app have one.

I have a hard time understanding why all the apps I developed do not worry about creating a trayicon and why this fabulous, well built program does not have that tiny feature that would make it perfect :)

Vistaus commented 6 years ago

@metal3d But even if Timm eventually wanted to, it's far too late now anyway to implement it anyway 'cause Corebird will soon stop working: https://www.patreon.com/posts/corebirds-future-18921328

metal3d commented 6 years ago

Yes I saw that a few days ago... didn't know that Twitter is so bad...