baegwangbin / DSINE

[CVPR 2024 Oral] Rethinking Inductive Biases for Surface Normal Estimation
https://baegwangbin.github.io/DSINE/
Other
685 stars 28 forks source link

Meet error when using torch hub #7

Open HLinChen opened 4 months ago

HLinChen commented 4 months ago

Meet error when using torch hub:

image

I think replacing utils.pad_input with utils.get_padding can solve this error.

oliver-batchelor commented 4 months ago

Not the only problem there..

  File "/home/oliver/.cache/torch/hub/hugoycj_DSINE-hub_main/hubconf.py", line 45, in infer_pil
    intrins = utils.get_intrins_from_fov(new_fov=60.0, H=orig_H, W=orig_W, device=self.device).unsqueeze(0)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'utils.utils' has no attribute 'get_intrins_from_fov'
hugoycj commented 4 months ago

@oliver-batchelor @HLinChen I discovered that the error mentioned earlier was caused by the removal of some functions, namely rename and remove, from the utils.py. To address this issue, I have added these utility functions back into the hubconf.py.

Moving forward, I plan to refactor hubconf.py to support the latest version DSINE and support loading of different version DSINE models

HLinChen commented 4 months ago

Thanks for your reply. By the way, what's the difference between different version saving_iterations?