baffler / OBS-OpenVR-Input-Plugin

This OBS plugin provides an input plugin to 64bit OBS that allows capturing directly from OpenVR/SteamVR mirror surface in full resolution.
GNU General Public License v2.0
374 stars 35 forks source link

Does not work with latest version of SLOBS #6

Closed whispervr closed 5 years ago

whispervr commented 5 years ago

The Latest update today 10-4-18 has made it so you can add it as a source but not set it's properties such as the cropping making it impossible to use for vr streaming on slobs now. Streamlabs told me I am not allowed to rollback the update nor stop their automatic updates either,

baffler commented 5 years ago

I'm not really sure what the issue is here. I initially set this up to work with OBS Studio only and @ocgineer made some changes to work with SLOBS. I don't know enough about SLOBS to figure out what the problem is. I'm not seeing any errors or anything in the SLOBS log files.

punkykari commented 5 years ago

Wanted to add to this. I started using the openvr plugin on the previous version of streamlabs and it worked fine, albeit a little glitchy with the properties menu. After the update, I reinstalled the plugin but now the properties menu doesn't open at all. I can add openvr plugin as a source and see it fine, but double clicking it or right clicking and selecting properties does nothing.

ocgineer commented 5 years ago

I'll have a look at this if I can find something, might be that they changed something on the front end that broke the whitelist of the plugin or the creation of the child window for the properties 🤔

baffler commented 5 years ago

Btw, there is a workaround I found with SLOBS for now. It will show the full eye when you add it as a source. You can either add a crop filter (right click OpenVr Capture > Filters > click the "+" and choose "Crop/Pad") or something I found a bit easier to do, just click on the source in the preview part, click and drag it to the right side, the click on the left resize square and just resize it until it fits well in the preview window. You can see an example in the attached pictures.

streamlabs obs_2018-10-14_12-51-16 streamlabs obs_2018-10-14_12-51-34

KitBallard64 commented 5 years ago

This is about SLOBS: For me to even get the camera to show up, I have to double click the OpenVr Plugin. Any attempt to click OpenVr then click "add source" shows a "No" symbol on the mouse. When you Double click and it opens the "add" window, it won't close the window when you click "add new source" from that window. It'll still add one though. Properties still doesn't work though. Went ahead and made a crop for now.

ocgineer commented 5 years ago

I found the issue, they changed the way how the sources are being populated in the available sources that are "whitelisted" and due to this, they made a small typo of the ID of the plugin. I do a fix pull request on the SLOBS source code to resolve this, its just then depends on when they push this to the live build.

ocgineer commented 5 years ago

Also it seems that the path for plugins has slightly changed and is by default now C:\Program Files\Streamlabs OBS\resources\app.asar.unpacked\node_modules\obs-studio-node\ directly (there is no libobs folder anymore as before 0.10 update.)

ocgineer commented 5 years ago

Just a heads up (sorry for the spam) but the issue has been resolved in SLOBS 0.11.2-preview.1 so it will be in the 0.11.2 live build is once it is released to everyone.

ocgineer commented 5 years ago

This can be closed, SLOBS 0.11.2 and up works again normally though @baffler can you update the "installation" path to C:\Program Files\Streamlabs OBS\resources\app.asar.unpacked\node_modules\obs-studio-node (both in readme.md and on the 1.2 release) as there is no libobs folder anymore.