Open fuhrmanator opened 3 years ago
Putting up a PR sounds great.
SInce you merged, can you publish the package on npm?
Published.
The issue should probably be closed now, I noticed the 2.3.4
, 2.3.5
, 2.3.6
and 3.0.0
tags / releases are missing from github
First, thanks for making tplant! It is very useful!
The composition flag is good, but I'm suggesting the following improvements. Let me use this example from
test/Raytracer/Scene.ts
:The PlantUML produced using the composition flag should be
Here are my reasons:
*--
), many of which are not truly the semantics of composition. It's pretty hard to figure that out from static analysis of source code, I think. Edit: Furthermore, aggregation (to many) isn't really any different than an association in UML, so a simpler link is just to use--
.Scene.things: Thing[];
implies one can navigate from the class Scene to one or more Thing. Edit: Hence, I suggest-->
."things" Thing
as above, and a cardinality such as"*" Thing
. Maybe combining them?which doesn't always look so great, but is useful I think.
Edit: in cases of a single reference, e.g.
myThing: Thing
the cardinality would be "1"I'd be happy to try a PR to support some of these things (with tests, of course), if you think they're reasonable.