search

bagetter / BaGetter

A lightweight NuGet and symbol server
https://www.bagetter.com
MIT License
269 stars 57 forks source link

Take it graceful if the icon file cannot be found #177

Open lg2de opened 3 months ago

lg2de commented 3 months ago

In case the icon cannot be found we should not get a fatal error in the logging.

Addresses #174

Regenhardt commented 3 months ago

I think this isn't enough. If the case happens where HasEmbeddedIcon is true but no icon is found, there's something more wrong than just a missing icon. Either the database or the file system would be inconsistent, which would be a way bigger problem than just one crashing package download, in which case BaGetter shouldn't just return no icon but prompt people to fix it.

The HasEmbeddedIcon property isn't just used in this one case either. The icon also is displayed as part of the metadata in several places, depending on that property. The data being inconsistent with the files would break those too, even though that probably wouldn't be critical bugs but just display errors. Still errors though.

I would be open to try/catching this error on the web UI though in order to provide actionable information about database and file system being inconsistent. That way the core code, which is in itself consistent, stays like it is, but the error is still caught and (hopefully) fixed.