search

bagetter / BaGetter

A lightweight NuGet and symbol server
https://www.bagetter.com
MIT License
167 stars 39 forks source link

Activate .NET code analysis #48

Closed Regenhardt closed 5 months ago

Regenhardt commented 5 months ago

Taken from the open BaGet PR https://github.com/loic-sharma/BaGet/pull/784

FroggieFrog commented 5 months ago

According to the build workflow, there is still one issue left: grafik

FroggieFrog commented 5 months ago

Maybe you can integrate 2 more changes from PR #46 (then #46 is superfluous and can be closed)

  1. in src/BaGetter.Core/Entities/Converters/StringArrayToJsonConverter.cs: line 14 v => (!string.IsNullOrEmpty(v)) ? JsonConvert.DeserializeObject<string[]>(v) : Array.Empty<string>())
  2. in tests/BaGetter.Tests/HostIntegrationTests.cs: line 65 .CreateHostBuilder(Array.Empty<string>())
seriouz commented 5 months ago

@Regenhardt Can you merge?