baggepinnen / ControlSystemIdentification.jl

System Identification toolbox, compatible with ControlSystems.jl
https://baggepinnen.github.io/ControlSystemIdentification.jl/dev
MIT License
130 stars 13 forks source link

add option to penalize curvature in `okid` impulse response #131

Closed baggepinnen closed 1 year ago

baggepinnen commented 1 year ago

also apply scaling of the estimated response with the sample time in order to match continuous-time response

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 46.15% and project coverage change: -0.21% :warning:

Comparison is base (e6f4f7c) 86.66% compared to head (ac02944) 86.46%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #131 +/- ## ========================================== - Coverage 86.66% 86.46% -0.21% ========================================== Files 12 12 Lines 2213 2224 +11 ========================================== + Hits 1918 1923 +5 - Misses 295 301 +6 ``` | [Flag](https://app.codecov.io/gh/baggepinnen/ControlSystemIdentification.jl/pull/131/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fredrik+Bagge+Carlson) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/baggepinnen/ControlSystemIdentification.jl/pull/131/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fredrik+Bagge+Carlson) | `86.46% <46.15%> (-0.21%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fredrik+Bagge+Carlson#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/baggepinnen/ControlSystemIdentification.jl/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fredrik+Bagge+Carlson) | Coverage Δ | | |---|---|---| | [src/subspace.jl](https://app.codecov.io/gh/baggepinnen/ControlSystemIdentification.jl/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fredrik+Bagge+Carlson#diff-c3JjL3N1YnNwYWNlLmps) | `81.22% <46.15%> (-1.48%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.