search

baggepinnen / ControlSystemIdentification.jl

System Identification toolbox, compatible with ControlSystems.jl
https://baggepinnen.github.io/ControlSystemIdentification.jl/dev
MIT License
132 stars 13 forks source link

ar redefinition #64

Closed mapi1 closed 3 years ago

mapi1 commented 3 years ago

This is what I took from our discussion here #62 , I also added a simple documentation to iddata(). What do you think, is it now clearer and sufficiently documented? Also the docstring got quite long, maybe it makes sense to split it with # Extended help, so the example is only shown when one uses ??ar.

baggepinnen commented 3 years ago

Excellent, thanks for another great PR! I don't mind the docstring being a bit lengthy, I've never once called ?? myself so I would have totally missed the nice example if it was hidden behind another ? :)