search

baggepinnen / ControlSystemIdentification.jl

System Identification toolbox, compatible with ControlSystems.jl
https://baggepinnen.github.io/ControlSystemIdentification.jl/dev
MIT License
132 stars 13 forks source link

Use tridiagonal parametrization in newpem #91

Closed baggepinnen closed 2 years ago

baggepinnen commented 2 years ago

An A-matrix on tridiagonal form reduces the number of parameters while keeping the optimization landscape well behaved

codecov[bot] commented 2 years ago

Codecov Report

Merging #91 (169dd52) into master (0222ba8) will increase coverage by 0.38%. The diff coverage is 92.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   83.64%   84.03%   +0.38%     
==========================================
  Files          12       12              
  Lines        2006     2092      +86     
==========================================
+ Hits         1678     1758      +80     
- Misses        328      334       +6
Flag Coverage Δ
unittests 84.03% <92.98%> (+0.38%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pem.jl 84.29% <92.79%> (+6.40%) :arrow_up:
src/types.jl 70.43% <100.00%> (-0.44%) :arrow_down:
src/ControlSystemIdentification.jl 76.37% <0.00%> (-0.19%) :arrow_down:
src/subspace2.jl 88.91% <0.00%> (+0.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0222ba8...169dd52. Read the comment docs.