search

bagisto / bagisto

Free and open source laravel eCommerce platform
https://bagisto.com
Open Software License 3.0
14.52k stars 2.15k forks source link

Class 'Faker\Factory' not found #2847

Closed emperorjm closed 4 years ago

emperorjm commented 4 years ago

Bagisto: version 1.1.0

In Bagisto v1.0.0 the faker class was a part of the require section in the composer.json file now it has been moved to the require-dev section which in my mind should be the correct setting for production environments but there is a Helper file in the CORE package that uses the Faker class for some reason (packages/Webkul/Core/src/Helpers/Laravel5Helper.php).

rahulcs0082 commented 4 years ago

Hi @emperorjm

We have reverted this these dependency. Thanks for notifying us.

vaishaliwebkul commented 4 years ago

@emperorjm We are closing this issue. Feel free to reopen this bug if not resolved Thanks.