Sort-order fields should not accept negative values in the theme. - Githubissues

bagisto / bagisto

Free and open source laravel eCommerce platform

https://bagisto.com

Open Software License 3.0

15.38k stars 2.21k forks source link

Sort-order fields should not accept negative values in the theme. #8454

Closed Amitk-webkul closed 1 year ago

Amitk-webkul commented 1 year ago

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

master

Issue Description

Sort-order fields should not accept negative values in the theme.

Note:- Fix the same for all the sorting fields.

Preconditions

1, Admin should be logged in.

Steps to reproduce

Go to 'Admin panel'
Click on 'Edit any option' in the settings/theme
Enter a negative value in the sort order and save it.
See the error

Expected Result

It should not accept the negative value in the sort order fields for all.

Actual Result

it is accepted in all the sort order fields. Here

Screenshots

No response

Additional context

No response

Amitk-webkul commented 1 year ago

Now, this issue is fixed. so I am closing this issue. And I have attached a screenshot Here, for future reference.