bagit-profiles / bagit-profiles-validator

A simple Python module for validating BagIt Profiles.
The Unlicense
12 stars 6 forks source link

if a tag is not required and not present, don't check whether value in 'values' #13

Closed kba closed 5 years ago

kba commented 5 years ago

A profile can mark a value as not required yet define an enumeration of values:

# [...]
Bag-Info:
  Enumerated-Tag:
    required: false
    default: "one"
    values: ["one", "two", "three"]

Currently, this raises a KeyError because the validator assumes that the presence of values implies required.

ruebot commented 5 years ago

Good catch!