Validate tag files allowed

bagit-profiles / bagit-profiles-validator

A simple Python module for validating BagIt Profiles.

The Unlicense

12 stars 6 forks source link

Validate tag files allowed #14

Closed kba closed 5 years ago

kba commented 5 years ago

c.f. https://github.com/bagit-profiles/bagit-profiles/pull/14

check whether Tag-Files-Required is a subset of Tag-Files-Allowed
check whether exisiting tag files are in Tag-Files-Allowed

In both cases wildcards (i.e. fnmatch patterns) are respected.

Also simplifies how validate() calls the individual validation methods and saves errors on a property report to inspect the errors detected in each call of validate().

ruebot commented 5 years ago

Weird. CircleCI hasn't run.

Other than that, nice work!

kba commented 5 years ago

Force-pushed to trigger CircleCI, tests pass now.

ruebot commented 5 years ago

Huh. This is now failing locally for me, and on CircleCI. Did I miss something?

kba commented 5 years ago

Fixed the error in https://github.com/bagit-profiles/bagit-profiles-validator/pull/16