search

bagit-profiles / bagit-profiles-validator

A simple Python module for validating BagIt Profiles.
The Unlicense
12 stars 6 forks source link

Fixes #16

Closed kba closed 5 years ago

kba commented 5 years ago

One error was because https://github.com/bagit-profiles/bagit-profiles/blob/master/bagProfileBar.json changed.

The other error was because absolute paths were checked against relative wildcards. No idea how that slipped through.

ruebot commented 5 years ago

Ah, I see now. Tests run fine locally for me.

I have really limited experience with CircleCI, and confused why the tests aren't triggering consistently on pull requests. I've never seen this with TravisCI. Any idea what's going on here? Something configured wrong maybe?

kba commented 5 years ago

No idea, web hooks getting lost in some queue on either Github or CircleCI side I guess. It finished successfully though https://circleci.com/gh/kba/bagit-profiles-validator/tree/fixes

This does happen with Travis as well, though not as often. With Travis, it often happens that builds fail because network glitches on their part prevent a container booting.

Main reason why I prefer CircleCI is that it is much faster and uses newer containers (Travis is still running ubuntu 14.04).

ruebot commented 5 years ago

screenshot from 2018-12-06 08-59-42

The default for this is "off".

kba commented 5 years ago

The default for this is "off".

That's to prevent people stealing any environment secrets (eg AWS keys) by sending a PR with malicious code.

I can't wrap my head around it right now why not this was built at all if PR building was off. Or why in https://github.com/bagit-profiles/bagit-profiles-validator/pull/17 only 2 of 5 tests sent success status.

If nothing else works, "Restart workflow" (Circle) or "Rebuild" (Travis) usually does.

ruebot commented 5 years ago

Yeah, it's definitely behaving strangely. I don't see this or the other two PRs here. Am I missing something?