Closed kba closed 5 years ago
@kba, we have #5 merged now. Let me know the order you'd like to move forward with the outstanding PRs.
Hi, thanks. I merged master into #8 and rebased the other PRs against #8, so a sensible order would be:
If you are okay with all of these and don't want to resolve conflicts, feel free to merge my dev branch into master, it contains these commits and will mark all the PR as merged.
Let's do them separate, so we have commits for each.
Let's do them separate, so we have commits for each.
They are still separate commits, it just has the branches merged with conflicts resolved.
Oh, I mean squashed commits for each unit of work in the pull requests.
Adds the possibility to pass the profile as a constructor arg, circumventing fetching via HTTP. The
url
parameter is still required. Here's the unit test to see what it does:We need to run many processes to quickly check profile adherence and running the same HTTP request over and over seems wasteful. When testing, it's also easier to pass a local profile. But we still need to verify that the
BagIt-Profile-Identifier
matches.(blocked by #5)