search

bahamas10 / hue-cli

A command line interface to phillips hue
http://bahamas10.github.com/hue-cli/
221 stars 24 forks source link

pointed hue.js dependency to bahamas10 forked fix #7

Closed kweiberth closed 9 years ago

kweiberth commented 9 years ago

I was unable to use your hue-cli bc the hue.js repo owner hasn't yet merged your pull request to fix the bug on node 0.12.x. I forked your repo and pointed the hue.js dependency to your forked fix. Then, I pushed this up to my fork. I then re-installed hue-cli by pointing it to my fork, like so: sudo install -g https://github.com/YBerth13/hue-cli/tarball/master, and it's working. I'm pretty new to git and github and programming in general, but I decided it made sense to submit a pull request, right?

If I'm not mistaken, if you were to accept this pull request, then when people run the standard npm install -g hue-cli, it should install the your forked, fixed version of hue.js, correct? I guess the best thing right now would be if that hue.js accepts your pull request soon.

bahamas10 commented 9 years ago

thanks!! it's not a fantastic solution, but it fixes what is currently broken

bahamas10 commented 9 years ago 
$ npm publish
+ hue-cli@0.1.0
kweiberth commented 9 years ago

Yeah agreed. Hopefully the hue.js repo gets updated soon. Thanks for merging it!