bahanonu / ciatah

CIAtah (pronounced cheetah): a software package for calcium imaging analysis of one- and two-photon imaging datasets. Documentation: https://git.io/ciatah_docs. Formerly known as calciumImagingAnalysis (ciapkg).
https://git.io/ciatah_docs
MIT License
80 stars 20 forks source link

New error in modelGetSignalsImages #33

Open omidm7 opened 4 years ago

omidm7 commented 4 years ago

Hey Biafra! Since pulling the newest updates in the master, I am running into a new error code after running cnmf-e. Everything seems to be fine until the very end, when I get this error: image

... Which leads to this error: image

Do you know what could be causing this? I have attached the full command window output. Omid Untitled 2.pdf

bahanonu commented 4 years ago

@omidm7 Yep, seems calciumImagingAnalysis.m is missing that property on this repository (it's on my internal one).

Let me know if the pull request below fixes the issue. I'll do a full pull request with other updates later (mouse surgeries call). https://github.com/bahanonu/calciumImagingAnalysis/pull/34

omidm7 commented 4 years ago

Hey @bahanonu, this morning I'm getting the getSignalsImage error in both the master and #34! Omid

bahanonu commented 4 years ago

@omidm7 Do you mean the same error as before or a different one?

omidm7 commented 4 years ago

Here is a screen shot of the error, it seems to be the getSignalsImage again: image

I also attached the full output: Untitled 2.pdf

bahanonu commented 4 years ago

Does the regular expression for finding the movie match the movie name in the folder? e.g. highlighted text below:

image

I'll add a check for when the class can't find a movie and notify user to check regular expression then re-run.

omidm7 commented 4 years ago

Ahh ok. The regEx was correct, but modelModifymovies had not finished correctly. Fixed it now, thanks!

omidm7 commented 4 years ago

Hi Biafra, have you ever encountered this "licensing error"?

image image

bahanonu commented 4 years ago

Only if a particular toolbox was not installed. If you type license('test','Image_Toolbox'), what is the output? Is your MATLAB from Stanford's CMGM (https://csbf.stanford.edu/software/)?

omidm7 commented 4 years ago

Yeah, I'm using MATLAB from the CMGM. The output for the line you gave me is ans = 1!

bahanonu commented 4 years ago

Strange, and you still get the license error for the image toolbox? If you try to use viewObjmaps or other functions besides CNMF-e, do you get errors?

omidm7 commented 4 years ago

Yeah, when I try running modelVarsfromfiles or viewObjmaps, I get license errors for Signals_Toolbox and Statistics_Toolbox. I'm gonna try to re-activate the MathWorks license tomorrow!

bahanonu commented 4 years ago

Re-activating end up solving the issue?

omidm7 commented 4 years ago

Apparently our lab's subscription to csbf had expired. I'm sure that's what was causing the licensing issue? I would have thought in that case Matlab wouldn't be able to open at all. I'm waiting for the admins to fix the subscription issue and I'll let you know! Thanks Biafra, Omid

omidm7 commented 4 years ago

Hey Biafra, quick question: After running cnmf-e , I get two cell maps. What is determining which cell is "accepted" at this point, before I've sorted using computeSortSignal? And is there I way I can sort through only the 1667 "accepted" cells rather than through the entire 2639 components?

image

bahanonu commented 4 years ago

Hey

It is determined by https://github.com/bahanonu/calciumImagingAnalysis/blob/master/image/filterImages.m or if you have the class loaded, type obj.filterImageOptions for a list of some of the defaults that you can change.

What does figure 4001 look like? That seems like a large # of cells for a ~200x350 movie, there might be a large # of duplicates (e.g. need to change cnmf-e merging, etc. criteria).

cheers, -Biafra

omidm7 commented 4 years ago

Thanks! This is how 4001 looks. Changing the cnmf-e merging parameters helps reduce duplicates in some data sets, but not others.

image

bahanonu commented 4 years ago

Thanks, what happens if you run PCA-ICA as a quick sanity check?

Also, can you save the fig 46 and 4001 outputs as .fig files and attach them here so I can take a look?

omidm7 commented 4 years ago

I can't attach .fig files here, so I'll email them to you right now.