Hello! I wanted to express my gratitude for the Rust crate you've developed. It has been an invaluable asset to my project, and I sincerely appreciate your contributions.
I made two critical changes that are well needed:
Edition Upgrade: I propose raising the crate's edition from 2018 to 2021. This change is necessary to meet the requirements of the pnet dependency.
Modifying the next_id(): Currently, the next_id() function demands a mutable reference (&mut self), but it is unnecessary since we internally utilize a mutex. There is no need for external mutability, and removing this requirement would make instance sharing much easier.
There is also a bit of refactoring here, replacing deprecated functions and solving two issues #14 and #18
I was a little lazy to scatter this on different PRs, so let it be such a big PR :D
Hello! I wanted to express my gratitude for the Rust crate you've developed. It has been an invaluable asset to my project, and I sincerely appreciate your contributions.
I made two critical changes that are well needed:
2018to2021. This change is necessary to meet the requirements of thepnetdependency.next_id(): Currently, thenext_id()function demands a mutable reference(&mut self), but it is unnecessary since we internally utilize a mutex. There is no need for external mutability, and removing this requirement would make instance sharing much easier.There is also a bit of refactoring here, replacing deprecated functions and solving two issues #14 and #18
I was a little lazy to scatter this on different PRs, so let it be such a big PR :D