Fix failure when some resource in not available or enhance with whitelist

lashchanka commented 2 years ago

In case you have part of resources unavailable (missing image e.g.) the plugin will fail with this error:

This issue has at least 2 negative sides:

You can't use plugin in your project, sometimes you are not able to fix the bugs on your own, so you have to avoid cyclope at all
Any bug with 404 error will break the plugin here

A proposal here can be to add some glob pattern ignore list, so if the resource is unavailable, we can simply skip it:

require('cyclope/plugin')(on, config, {
      ignoreFailed: ['assets/**/*.png'],
  });

In case you wan't to ignore all failures:

require('cyclope/plugin')(on, config, {
      ignoreFailed: true,
  });

@bahmutov could you extend the plugin, please?

Thanks in advance 🙇

bahmutov commented 2 years ago

it would be a new feature, I guess I see why it is needed though

lashchanka commented 2 years ago

@bahmutov please, check PR to partially cover the request: https://github.com/bahmutov/cyclope/pull/64

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

bahmutov / cyclope