Plugin throws an error when there is an <img/> without src attribute

bahmutov / cyclope

Cypress DOM snapshots and consistent image diffing in the cloud

13 stars 2 forks source link

Plugin throws an error when there is an <img/> without src attribute #65

Closed kenzhemir closed 2 years ago

kenzhemir commented 2 years ago

When I run the cypress tests and test ends on a page where there is tag without src attribute, then plugin throws a hard to debug error message. It happens on this line https://github.com/bahmutov/cyclope/blob/main/src/index.js#L168 Plugin throws null value exception (can't find startsWith)

Would be nice if plugin would either ignore this empty img tag OR throw a proper error message

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.3.1 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: