search

bahmutov / cypress-split

Split Cypress specs across parallel CI machines for speed
MIT License
199 stars 21 forks source link

cypress-split always uses average duration #267

Open KleaTech opened 2 months ago

KleaTech commented 2 months ago

cypress-split finds and reads the timings file correctly, but cannot find the individual specs in it. The reason is that the path in the timings file and the path that cypress-split compares with are different, see image.

image

KleaTech commented 2 months ago

I think this solves it, but probably it would make sense to revisit the specAbsoluteToRelative approach

image

bahmutov commented 2 months ago

Mind opening a PR with a test that shows the problem and the fix?Sent from my iPhoneOn Apr 12, 2024, at 07:49, Adam Bozzay @.***> wrote: I think this solves it, but probably it would make sense to revisit the specAbsoluteToRelative approach image.png (view on web)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

KleaTech commented 2 months ago

I check if I can write a test that indicates the issue.

The fix I suggested works, but I think it's more of a workaround. It's even possible that the best place for the fix is in find-cypress-specs.